Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running pip check in conda environments shouldn't fail #1531

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Running pip check in conda environments shouldn't fail #1531

merged 5 commits into from
Nov 16, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 16, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Forces the results of pip check for conda builds to always exit 0
  • Use python -m for calling workflow python commands
  • Fixes the malformed link to the build status

Does this PR introduce a breaking change?

No.

Other information:

It seems that there's a bit of a lag on the conda side of things when it comes to dependencies. The bug causing these failures has been addressed upstream: conda/conda#13258

@Zeitsperre Zeitsperre self-assigned this Nov 16, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Nov 16, 2023
@github-actions GitHub Actions
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.9.12).

No further action is required.

@Zeitsperre Zeitsperre added this to the v0.47.0 milestone Nov 16, 2023
@github-actions github-actions bot added the approved Approved for additional tests label Nov 16, 2023
@github-actions github-actions bot added the docs Improvements to documenation label Nov 16, 2023
@Zeitsperre Zeitsperre merged commit 71dead7 into master Nov 16, 2023
17 checks passed
@Zeitsperre Zeitsperre deleted the reduce-conda-failures branch November 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @juliettelavoie